Files that changed from the base of the PR and between 08caf8f and b6de017.

• client/chain/ofac.go (1 hunks)

client/chain/ofac.go (2)

Line range hint 1-93: General improvements for OFAC handling

After reviewing the entire file, here are some suggestions for improvement:

1. Make the OFAC list URL configurable:
   Instead of hardcoding defaultOfacListURL, consider using an environment variable or a configuration file. This would allow for easier updates and environment-specific URLs.

   var ofacListURL = os.Getenv("OFAC_LIST_URL")
   if ofacListURL == "" {
       ofacListURL = "https://raw.githubusercontent.com/InjectiveLabs/injective-lists/master/wallets/ofac.json"
   }

2. Use more inclusive terminology:
   Replace IsBlacklisted with a more neutral term like IsRestricted or IsOnSanctionsList.

   func (oc *OfacChecker) IsRestricted(address string) bool {
       return oc.ofacList[address]
   }

3. Implement periodic updates:
   Consider adding a goroutine that periodically checks for updates to the OFAC list and refreshes the local copy if necessary.

These changes would improve the flexibility, inclusivity, and up-to-date nature of the OFAC checking system.

Let's verify the current update mechanism and usage of the IsBlacklisted function:

#!/bin/bash
# Description: Check for update mechanisms and usage of IsBlacklisted

# Test 1: Look for any update mechanisms
echo "Searching for update mechanisms:"
rg --type go "update.*ofac"

# Test 2: Check usage of IsBlacklisted
echo "Usage of IsBlacklisted:"
rg --type go "IsBlacklisted"

---

43-43: Simplification introduces potential fragility

The simplified getOfacListPath function removes the previous directory traversal logic, which makes the code cleaner but potentially less robust. Consider the following points:

1. The function now assumes a fixed directory structure relative to the current working directory. This might break if:

   • The function is called from a different working directory.
   • The project structure changes.

2. There's no error handling for os.Getwd(), which could fail in certain environments.

To improve robustness, consider:

1. Using an absolute path or an environment variable to locate the OFAC list file.
2. Adding error handling for os.Getwd().

Here's a potential improvement:

func getOfacListPath() (string, error) {
    currentDirectory, err := os.Getwd()
    if err != nil {
        return "", fmt.Errorf("failed to get current directory: %w", err)
    }
    return filepath.Join(currentDirectory, "../metadata", ofacListFilename), nil
}

This change would require updating the callers of getOfacListPath to handle the potential error.

Let's verify the usage of getOfacListPath in the codebase:

Verification successful

[/run_scripts]

---

[/run_scripts]

---

[/run_scripts]

---

Path to OFAC list is correctly defined and accessible

The getOfacListPath function accurately points to client/metadata/ofac.json, which exists in the repository. No issues were found with the current implementation.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check usage of getOfacListPath and potential impacts

# Test 1: Find all occurrences of getOfacListPath
echo "Occurrences of getOfacListPath:"
rg --type go "getOfacListPath"

# Test 2: Check if there are any other files in the metadata directory
echo "Files in ../metadata directory:"
fd . "../metadata"

Length of output: 650

---

Script:

#!/bin/bash
# Description: Check usage of getOfacListPath and potential impacts

# Test 1: Find all occurrences of getOfacListPath
echo "Occurrences of getOfacListPath:"
rg --type go "getOfacListPath"

# Test 2: Check if there are any other files in the metadata directory
echo "Files in ../metadata directory:"
fd . "../metadata"

Length of output: 604

---

Script:

#!/bin/bash
# Description: Locate all 'metadata' directories and list their contents

# Test 1: Find all directories named 'metadata'
echo "Searching for all 'metadata' directories in the repository:"
fd metadata --type d

# Test 2: For each found 'metadata' directory, list its contents
echo "Listing contents of each 'metadata' directory:"
fd metadata --type d -x ls -la {}

Length of output: 1739

---

Script:

#!/bin/bash
# Description: Locate the definition of 'ofacListFilename' and verify its usage

# Test 1: Find the definition of 'ofacListFilename'
echo "Searching for the definition of 'ofacListFilename':"
rg --type go "ofacListFilename\s*="

# Test 2: Find all occurrences of 'ofacListFilename' to understand its usage
echo "Occurrences of 'ofacListFilename' in the codebase:"
rg --type go "ofacListFilename"

# Test 3: Verify if 'ofac.json' exists in 'client/metadata/' directory
echo "Checking for 'ofac.json' in 'client/metadata/':"
fd ofac.json client/metadata/

# Test 4: List all 'ofac.json' files in the repository
echo "Listing all 'ofac.json' files in the repository:"
fd ofac.json --type f

Length of output: 1272